[dm-devel] [PATCH] multipathd/cli_handlers cli_resize : check pp and pgp before calling them to avoid multipathd core dump.

taget at linux.vnet.ibm.com taget at linux.vnet.ibm.com
Mon Jun 17 03:53:22 UTC 2013


From: Eli Qiao <taget at linux.vnet.ibm.com>

Signed-off-by: Eli Qiao <taget at linux.vnet.ibm.com>
---
 multipathd/cli_handlers.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c
index 7b1cb62..4b860bb 100644
--- a/multipathd/cli_handlers.c
+++ b/multipathd/cli_handlers.c
@@ -603,7 +603,18 @@ cli_resize(void *v, char **reply, int *len, void *data)
 	}
 
 	pgp = VECTOR_SLOT(mpp->pg, 0);
+
+	if (!pgp){
+		condlog(0, "%s: couldn't get path group. cannot resize",
+			mapname);
+		return 1;
+	}
 	pp = VECTOR_SLOT(pgp->paths, 0);
+
+	if (!pp){
+		condlog(0, "%s: couldn't get path. cannot resize", mapname);
+		return 1;
+	}
 	if (!pp->udev || sysfs_get_size(pp, &size)) {
 		condlog(0, "%s: couldn't get size for sysfs. cannot resize",
 			mapname);
-- 
1.8.1.4




More information about the dm-devel mailing list