[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] Chicken and egg problem with multipath-tools



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/04/2013 11:13 AM, Hannes Reinecke wrote:
> multipathd/main.c:1996 /* Startup complete, create logfile */ 
> pid_rc = pidfile_create(DEFAULT_PIDFILE, daemon_pid); /* Ignore
> errors, we can live without */
> 
> 
> No option, but multipathd doesn't _need_ to create a pidfile. And
> it certainly won't abort if it cannot create one.

Maybe an old version (prior to commit 6cda789 in May 2011)?

- -       if (pidfile_create(DEFAULT_PIDFILE, getpid())) {
- -               if (logsink)
- -                       log_thread_stop();
+       if (pidfile_create(DEFAULT_PIDFILE, getpid()))
+               /* Ignore errors, we can live without */
+               condlog(1, "failed to create pidfile");

- -               exit(1);
- -       }

If this is the case then using a more recent multipath-tools would
definitely be a good plan.

Regards,
Bryn.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlE0hTgACgkQ6YSQoMYUY96+8wCdG/zOh6fDAOW2LzCNitHNTiek
VzkAn3ovG1230AQMPV/uRcVk8pA1emN/
=o2M/
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]