[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 16/24] dm cache: log error message if dm_kcopyd_copy() fails



On Thu, Oct 24, 2013 at 02:30:29PM -0400, Mike Snitzer wrote:
> A migration failure should be logged (albeit limited).
 
Does this *really* add anything useful?

migration_failure() already always logs a message, so you'll now get
two (throttled) messages instead of one every time.

Would it be better to log not just the type of failure but also some
details about the data block location too?

And if you really need to know "issuing migration failed" then why not
just add the string to the existing log message?

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]