[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] libmultipath/discovery.c: Fix a condition that will lead to a table reload during every check.



Applied.
Thanks.

Christophe Varoqui
www.opensvc.com



On Thu, Nov 14, 2013 at 1:06 AM, Sean Stewart <sean stewart netapp com> wrote:
If path_offline says PATH_UP and the checker says PATH_DOWN.  In
this case, pathinfo gets called twice, and the first call, from
update_prio sets it to -1 because the checker says it's down.  On the
second pathinfo call, from update_path_groups, it will call the
prioritizer based on the fact that the prio is -1. This leads to a flip
flop of the priority value and a reload on every check.

Signed-off-by: Sean Stewart <sean stewart netapp com>
---
 libmultipath/discovery.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index 7035a43..04e3ead 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1138,8 +1138,6 @@ pathinfo (struct path *pp, vector hwtable, int mask)
                        if (!strlen(pp->wwid))
                                get_uid(pp);
                        get_prio(pp);
-               } else {
-                       pp->priority = PRIO_UNDEF;
                }
        }

--
1.8.3.1



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]