[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 04/13] libmultipath: return error numbers from sysfs_get_XXX



On 11/17/2013 06:34 PM, Christophe Varoqui wrote:
>  declare_sysfs_get_str(devtype);
> -declare_sysfs_get_str(cutype);
>  declare_sysfs_get_str(vendor);
>  declare_sysfs_get_str(model);
>  declare_sysfs_get_str(rev);
> 
> This part seems correct, as this function is not used anywhere, but
> orthogonal to the patch.
> Can you confirm this slip is safe ?
> 
Yes. I've added the 'cutype' attribute back then when I've added
multipath support for DASD, but then it turned out this attribute
is not required (DASD selection relies on 'devtype').

So it's safe to remove it.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare suse de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]