[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/1] improve the performance of dm-log-userspace



于 2013年11月21日 18:26, Akira Hayakawa 写道:
Hi, Dongmao

I think you are using workqueue the wrong way in two places.

1)
WQ_NON_REENTRANT is deprecated. You should remove it.
+	if (lc->integrated_flush) {
+		lc->dmlog_wq = alloc_workqueue("dmlogd", WQ_NON_REENTRANT | WQ_MEM_RECLAIM, 0);

2)
destory_workqueue first calls drain_workqueue which
then calls flush_workqueue. You should remove the first line of these.
+		flush_workqueue(lc->dmlog_wq);
+		destroy_workqueue(lc->dmlog_wq);

Akira

OK, thank you very much



--
dm-devel mailing list
dm-devel redhat com
https://www.redhat.com/mailman/listinfo/dm-devel



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]