[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 01/24] dm: nest targets used for testing under DM_TEST_TARGETS



On Thu, Oct 24 2013 at  7:17pm -0400,
Alasdair G Kergon <agk redhat com> wrote:

> > --- a/drivers/md/Kconfig
> > +++ b/drivers/md/Kconfig
> > @@ -371,27 +371,12 @@ config DM_MULTIPATH_ST
>   	  
> > -config DM_DELAY
> > -	tristate "I/O delaying target"
> 
> > +config DM_DELAY
> > +	tristate "I/O delaying target (EXPERIMENTAL)"
> 
> Why has EXPERIMENTAL reappeared???
> See d57916a00fd749ccd354a7f754c2aba98f86d064
> 
> Please regenerate these patches against an up-to-date upstream base!

The base for these patches is v3.12-rc5, certainly recent enough.

What you took issue with here has nothing to do with an older base being
used for the patches.  It has everything to do with Joe having made this
change in his thin-dev branch quite a while ago -- when I rebased I
didn't change the text the patch moved.  Will remove the EXPERIMENTALs.

As for delay being useful for non-test use-cases, that may be but
classifying it as a target that is used for testing is fair (hence
"Useful for testing." in the DM_DELAY help text).  That said, if you'd
really prefer DM_DELAY not be nested under DM_TEST_TARGETS I can revert
it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]