[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] dm mpath: do not fail path on -ENOSPC



On 09/13/2013 07:54 AM, Jun'ichi Nomura wrote:
> Since ENOSPC is a target-side error, dm-mpath should just pass the error
> information to upper layer instead of retrying itself with path failover.
> Otherwise it will end up failing all paths down while path checkers find
> all paths ok.
> 
> ENOSPC can now be returned from SCSI device after commit a9d6ceb8
> ("[SCSI] return ENOSPC on thin provisioning failure").
> 
> Signed-off-by: Jun'ichi Nomura <j-nomura ce jp nec com>
> Cc: Hannes Reinecke <hare suse de>
> ---
>  drivers/md/dm-mpath.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> The patch is not actually tested as I don't have such a storage at my hand.
> Hannes, please let me know if you didn't change noretry_error() intentionally.
> 
No, you are correct. I've missed this bit when sending out the
enhanced I/O errors patch.

Acked-by: Hannes Reinecke <hare suse de>

> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index b759a12..075747e 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1268,6 +1268,7 @@ static int noretry_error(int error)
>  	case -EREMOTEIO:
>  	case -EILSEQ:
>  	case -ENODATA:
> +	case -ENOSPC:
>  		return 1;
>  	}
>  
> 

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare suse de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]