[dm-devel] [PATCH for-dm-3.14-fixes 0/8] dm thin: address a few fundamental problems

Mike Snitzer snitzer at redhat.com
Fri Feb 21 02:55:57 UTC 2014


This patchset fixes various thinp issues.  Aside from fixing some bugs
in earlier 3.14-rc1 code (as noted with commit references): the most
significant issue addressed is that until now we didn't have the
awareness or ability to force the user to perform consistency checks
on the thin pool's metadata and data if warranted.

While there is a fair amount of change here I feel pretty strongly
that these fixes should get upstream ASAP.  Posting for review with
the hope that I'll get timely feedback/acks so that I can send to
Linus early next week.

(Alasdair, I went with "needs check" for the flag used in patch 7 even
though you initially disagreed with the name.. it is short and to the
point, and really: it is internal to the thin implementation.
Userspace can spin it however you'd like).

Mike Snitzer (8):
  dm thin: synchronize the pool mode during suspend
  dm thin: set flag when over the metadata low watermark threshold
  dm thin: set flag if metadata is out of space
  dm thin: error out I/O if inappropriate for it to be retried
  dm thin: fix the error path for the thin device constructor
  dm thin: fix pool_preresume resize with heavy IO races
  dm thin: ensure user takes action to validate data and metadata consistency
  dm thin: allow metadata space larger than supported to go unused

 Documentation/device-mapper/cache.txt              |  11 +-
 Documentation/device-mapper/thin-provisioning.txt  |  28 +++
 drivers/md/dm-cache-metadata.c                     |   2 +-
 drivers/md/dm-thin-metadata.c                      | 118 ++++++++++-
 drivers/md/dm-thin-metadata.h                      |  23 ++-
 drivers/md/dm-thin.c                               | 225 ++++++++++++++++-----
 drivers/md/persistent-data/dm-space-map-metadata.c |  19 +-
 .../md/persistent-data/dm-transaction-manager.c    |  13 +-
 .../md/persistent-data/dm-transaction-manager.h    |   2 +-
 9 files changed, 350 insertions(+), 91 deletions(-)

-- 
1.8.3.1




More information about the dm-devel mailing list