[dm-devel] [PATCH for-dm-3.14-fixes 4/8] dm thin: error out I/O if inappropriate for it to be retried

Joe Thornber thornber at redhat.com
Fri Feb 21 14:22:44 UTC 2014


NACK (but close).

On Thu, Feb 20, 2014 at 09:56:01PM -0500, Mike Snitzer wrote:
> If the pool is in fail mode, error_if_no_space is enabled or the
> metadata space is exhausted do _not_ allow IO to be retried.

This should be:

"If the pool is in fail mode, error_if_no_space is enabled or a
transaction has been aborted, do _not_ allow IO to be retried."

(In practise 'transaction has been aborted' is the same as the
needs_check flag we've discussed.)

- Joe




More information about the dm-devel mailing list