[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH for-dm-3.14-fixes 4/8] dm thin: error out I/O if inappropriate for it to be retried



On Fri, Feb 21 2014 at  9:22am -0500,
Joe Thornber <thornber redhat com> wrote:

> NACK (but close).
> 
> On Thu, Feb 20, 2014 at 09:56:01PM -0500, Mike Snitzer wrote:
> > If the pool is in fail mode, error_if_no_space is enabled or the
> > metadata space is exhausted do _not_ allow IO to be retried.
> 
> This should be:
> 
> "If the pool is in fail mode, error_if_no_space is enabled or a
> transaction has been aborted, do _not_ allow IO to be retried."
> 
> (In practise 'transaction has been aborted' is the same as the
> needs_check flag we've discussed.)

Yeah, which is made available in patch 7.  These are all building to the
final state in patch 7.  No shipping kernel should have the intermediate
state that these incremental patches introduce.

I left them split out to see the progression, as I think it useful.
If I folded all of these changes together it would be difficult to see
the progression.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]