[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH v2 7/7] dm snapshot: use bufio prefetch



On Mon, Jan 13 2014 at  5:00pm -0500,
Mikulas Patocka <mpatocka redhat com> wrote:

> No.
> 
> This changed patch inefficiently loops in bufio_prefetch_chunks for each 
> buffer that is read.

Yeah, I overlooked the importance of preserving prefetch_area (which
explains the unlikely you had).  But my intent was to make your code
less "special"; your if (DM_PREFETCH_CHUNKS) do { } while() code to
avoid the extra indentation is pretty ugly.

Given your current code, DM_PREFETCH_CHUNKS is always 12 so why not just
remove the check?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]