[dm-devel] dm: ioctl: use kvfree

Mike Snitzer snitzer at redhat.com
Mon Apr 11 15:17:15 UTC 2016


On Mon, Apr 11 2016 at 11:14am -0400,
Sudip Mukherjee <sudipm.mukherjee at gmail.com> wrote:

> We can use kvfree() instead of calling kfree() and vfree() based on
> if-else and param_flags. kvfree() will check the type of address and
> will call the respective function to free it.
> Additionally we can also remove the use of DM_PARAMS_KMALLOC and
> DM_PARAMS_VMALLOC.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee at codethink.co.uk>

Have you actually tested htis?  Last time I looked to do this it exposed
crashes.  I don't have time to dig into this again right now but this is
_not_ as simple as this patch implies.




More information about the dm-devel mailing list