[dm-devel] [PATCH] dm cache metadata: fix cmd_read_lock acquiring write lock
Ahmed Samy
f.fallen45 at gmail.com
Sun Apr 17 05:37:09 UTC 2016
commit 9567366fefdd ("dm cache metadata: fix READ_LOCK macros and cleanup WRITE_LOCK macros")
seemed to use down_write instead of down_read in cmd_read_lock(), yet
releasing it with up_read() in READ_UNLOCK. Fix it.
Cc: Mike Snitzer <snitzer at redhat.com>
Cc: stable at vger.kernel.org
Signed-off-by: Ahmed Samy <f.fallen45 at gmail.com>
---
drivers/md/dm-cache-metadata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 65ce698..3970cda 100644
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -894,9 +894,9 @@ static bool cmd_write_lock(struct dm_cache_metadata *cmd)
static bool cmd_read_lock(struct dm_cache_metadata *cmd)
{
- down_write(&cmd->root_lock);
+ down_read(&cmd->root_lock);
if (cmd->fail_io) {
- up_write(&cmd->root_lock);
+ up_read(&cmd->root_lock);
return false;
}
return true;
--
2.8.1.210.gb8b4d93
More information about the dm-devel
mailing list