[dm-devel] [PATCH 05/57] Add HP MSA 2040 to the hardware table

[Sebastian Herbszt]

Hannes Reinecke wrote:
> Signed-off-by: Hannes Reinecke <hare at suse.de>
> ---
>  libmultipath/hwtable.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

You missed adding it to multipath.conf.defaults.

> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index a4ae053..28ee595 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -175,6 +175,21 @@ static struct hwentry default_hw[] = {
>  		.prio_name     = PRIO_ALUA,
>  		.prio_args     = NULL,
>  	},
> +	{
> +		/* HP MSA 1040/2040 product family */
> +		.vendor        = "HP",
> +		.product       = "MSA (1|2)040 SA(N|S)",
> +		.features      = DEFAULT_FEATURES,
> +		.hwhandler     = DEFAULT_HWHANDLER,
> +		.pgpolicy      = GROUP_BY_PRIO,
> +		.pgfailback    = -FAILBACK_IMMEDIATE,
> +		.rr_weight     = RR_WEIGHT_NONE,
> +		.no_path_retry = 18,
> +		.minio         = 100,
> +		.checker_name  = TUR,
> +		.prio_name     = PRIO_ALUA,
> +		.prio_args     = NULL,
> +	},
>  
>  	{
>  		/* HP SVSP */

Any reason for a separate entry and not merging it with
"HP MSA2000 product family with new firmware" ?

Sebastian