[dm-devel] [PATCH] multipathd: fix waiter_attr resource leak

Benjamin Marzinski bmarzins at redhat.com
Fri Jul 8 19:33:14 UTC 2016


On Fri, Jul 08, 2016 at 09:59:18AM +0200, Christophe Varoqui wrote:

ACK

-Ben


>    Ben, Hannes, I'd appreciate your ack on this patch.
>    Thanks.
>    On Wed, Jul 6, 2016 at 10:08 AM, <[1]zhang.kai16 at zte.com.cn> wrote:
> 
>      As a global variable waiter_attr of thread attribute was set up in the
>      daemon,
>      however,it hasn't been destroyed when the daemon exited.
>      We need deinitialize waiter_attr.
>       
>      ---
>      multipathd/main.c | 3 +++
>      1 file changed, 3 insertions(+)
> 
>      diff --git a/multipathd/main.c b/multipathd/main.c
>      index b86374f..09c5485 100644
>      --- a/multipathd/main.c
>      +++ b/multipathd/main.c
>      @@ -2317,6 +2317,9 @@ child (void * param)
>                       conf = NULL;
>                       udev_unref(udev);
>                       udev = NULL;
>      +
>      +                 pthread_attr_destroy(&waiter_attr);
>      +
>      #ifdef _DEBUG_
>                       dbg_free_final(NULL);
>      #endif
>      --
>      1.9.1
> 
>  --------------------------------------------------------
>  ZTE Information Security Notice: The information contained in this mail (and any attachment transmitted herewith) is privileged and confidential and is intended for the exclusive use of the addressee(s).  If you are not an intended recipient, any disclosure, reproduction, distribution or other dissemination or use of the information contained is strictly prohibited.  If you have received this mail in error, please delete it and notify us immediately.
> 
> 
>      --
>      dm-devel mailing list
>      [2]dm-devel at redhat.com
>      [3]https://www.redhat.com/mailman/listinfo/dm-devel
> 
> References
> 
>    Visible links
>    1. mailto:zhang.kai16 at zte.com.cn
>    2. mailto:dm-devel at redhat.com
>    3. https://www.redhat.com/mailman/listinfo/dm-devel

> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel




More information about the dm-devel mailing list