[dm-devel] [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate

[Srinivas Ramani]

Hi Xose;

I agree.

/*
         * Pillar Data controller family
         *
         * Maintainer : Srinivasan Ramani
         * Mail : srinivas.ramani at oracle.com
         */
        {
                .vendor        = "^Pillar(  )?$",
                .product       = "^Axiom"
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = DEFAULT_MINIO,
                .checker_name  = TUR,
                .prio_name     = PRIO_ALUA,
        },
        /*
         * Oracle FS controller family
         *
         * Maintainer : Srinivasan Ramani
         * Mail : srinivas.ramani at oracle.com
         */
        {
                .vendor        = "^Oracle(  )?$",
                .product       = "^Oracle FS",
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = DEFAULT_MINIO,
                .checker_name  = TUR,
                .prio_name     = PRIO_ALUA,
        },




The patch would be attached patch.txt file.


Best Regards
Srini

-----Original Message-----
From: Xose Vazquez Perez [mailto:xose.vazquez at gmail.com] 
Sent: Saturday, July 30, 2016 5:03 PM
To: Srinivas Ramani
Cc: Christophe Varoqui; device-mapper development
Subject: Re: [PATCH] multipath-tools: Pillar/Axiom supports failback=immediate

On 07/31/2016 01:18 AM, Srinivas Ramani wrote:

Pillar/Axiom and "Oracle FS" configs look the same.

>                 .vendor        = "^Pillar(  )?$",
>                 .product       = "^Axiom"
>                 .getuid        = DEFAULT_GETUID,
>                 .features      = DEFAULT_FEATURES,
>                 .hwhandler     = DEFAULT_HWHANDLER,
>                 .selector      = DEFAULT_SELECTOR,
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = FAILBACK_UNDEF, <<<<<-----------

Why pgfailback is FAILBACK_UNDEF(manual)?, when in your /etc/multipath.conf template it's "immediate".

> Auto-generated template from Oracle FS Path Manager 4.0:
>         vendor                "^Pillar(  )?$"
>         product               "^Axiom"
>         path_grouping_policy  group_by_prio
>         prio                  oraclefspm
>         path_checker          oraclefspm
>         failback              immediate          <<<<<-----------
>         path_selector         "round-robin 0"
> 
> Template from Axiom Path Manager 3.1 for RHEL-6.1:
>         vendor               "Pillar"
>         product              "*"
>         path_grouping_policy group_by_prio
>         prio                 pillarapm
>         path_checker         pillarapm
>         failback             immediate          <<<<<-----------
>         no_path_retry        60
>         dev_loss_tmo         60
>         fast_io_fail_tmo     30

Thank you.
-------------- next part --------------
--- 1/hwtable.c 2016-07-31 15:03:56.614527157 -0700
+++ 2/hwtable.c 2016-07-31 15:04:02.599057789 -0700
@@ -764,17 +764,38 @@
         * Pillar Data controller family
         *
         * Maintainer : Srinivasan Ramani
-        * Mail : sramani at pillardata.com
+        * Mail : srinivas.ramani at oracle.com
         */
        {
-               .vendor        = "Pillar",
-               .product       = "Axiom.*",
+               .vendor        = "^Pillar(  )?$",
+               .product       = "^Axiom"
                .getuid        = DEFAULT_GETUID,
                .features      = DEFAULT_FEATURES,
                .hwhandler     = DEFAULT_HWHANDLER,
                .selector      = DEFAULT_SELECTOR,
                .pgpolicy      = GROUP_BY_PRIO,
-               .pgfailback    = FAILBACK_UNDEF,
+               .pgfailback    = -FAILBACK_IMMEDIATE,
+               .rr_weight     = RR_WEIGHT_NONE,
+               .no_path_retry = NO_PATH_RETRY_UNDEF,
+               .minio         = DEFAULT_MINIO,
+               .checker_name  = TUR,
+               .prio_name     = PRIO_ALUA,
+       },
+       /*
+        * Oracle FS controller family
+        *
+        * Maintainer : Srinivasan Ramani
+        * Mail : srinivas.ramani at oracle.com
+        */
+       {
+               .vendor        = "^Oracle(  )?$",
+               .product       = "^Oracle FS",
+               .getuid        = DEFAULT_GETUID,
+               .features      = DEFAULT_FEATURES,
+               .hwhandler     = DEFAULT_HWHANDLER,
+               .selector      = DEFAULT_SELECTOR,
+               .pgpolicy      = GROUP_BY_PRIO,
+               .pgfailback    = -FAILBACK_IMMEDIATE,
+               .rr_weight     = RR_WEIGHT_NONE,
+               .no_path_retry = NO_PATH_RETRY_UNDEF,
+               .minio         = DEFAULT_MINIO,
+               .checker_name  = TUR,
+               .prio_name     = PRIO_ALUA,
+       },