[dm-devel] scsi-debug regression with 4.5-rc?

Mike Snitzer snitzer at redhat.com
Fri Mar 4 15:24:09 UTC 2016


On Wed, Jan 20 2016 at 10:57am -0500,
Martin K. Petersen <martin.petersen at oracle.com> wrote:

> >>>>> "Ewan" == Ewan Milne <emilne at redhat.com> writes:
> 
> Ewan> So I have a report from our test people that the optimal_io_size
> Ewan> sysfs value is now different by a factor of 512 from what it used
> Ewan> to be...
> 
> Yes, just prepared a patch this morning. I messed up sectors vs. bytes.

Would your fix (commit d0eb20a863ba7dc) address this BZ too?
https://bugzilla.redhat.com/show_bug.cgi?id=1314687

Seems not, I think that BZ may be due to the LBPRZ clause in commit
397737223 ("sd: Make discard granularity match logical block size when LBPRZ=1") ?

should be: q->limits.discard_granularity = 1 * logical_block_size;

Mike




More information about the dm-devel mailing list