[edk2-devel] [PATCH v3 5/5] Platform/RaspberryPi: Trivial whitespace cleanup
Pete Batard
pete at akeo.ie
Mon Aug 31 13:17:45 UTC 2020
Thanks for this.
On 2020.08.28 23:02, Jeremy Linton wrote:
> Pete's review pointed out some whitespace issues in the
> context of a previous patch. Since there are a number of
> similar errors in the file lets fix them separately.
>
> Cc: Leif Lindholm <leif at nuviainc.com>
> Cc: Pete Batard <pete at akeo.ie>
> Cc: Andrei Warkentin <awarkentin at vmware.com>
> Cc: Ard Biesheuvel <ard.biesheuvel at arm.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
> Signed-off-by: Jeremy Linton <jeremy.linton at arm.com>
> ---
> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 +++++++++++-----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> index d58cbbdfe7..2712194d2b 100644
> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> @@ -209,9 +209,9 @@ SetupVariables (
> }
>
>
>
> Size = sizeof (UINT32);
>
> - Status = gRT->GetVariable(L"CustomCpuClock",
>
> - &gConfigDxeFormSetGuid,
>
> - NULL, &Size, &Var32);
>
> + Status = gRT->GetVariable (L"CustomCpuClock",
>
> + &gConfigDxeFormSetGuid,
>
> + NULL, &Size, &Var32);
>
> if (EFI_ERROR (Status)) {
>
> Status = PcdSet32S (PcdCustomCpuClock, PcdGet32 (PcdCustomCpuClock));
>
> ASSERT_EFI_ERROR (Status);
>
> @@ -256,9 +256,9 @@ SetupVariables (
> PcdSet32 (PcdFanOnGpio, PcdGet32 (PcdFanOnGpio));
>
> }
>
>
>
> - Size = sizeof(AssetTagVar);
>
> + Size = sizeof (AssetTagVar);
>
>
>
> - Status = gRT->GetVariable(L"AssetTag",
>
> + Status = gRT->GetVariable (L"AssetTag",
>
> &gConfigDxeFormSetGuid,
>
> NULL, &Size, AssetTagVar);
>
>
>
> @@ -267,7 +267,7 @@ SetupVariables (
> L"AssetTag",
>
> &gConfigDxeFormSetGuid,
>
> EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,
>
> - sizeof(AssetTagVar),
>
> + sizeof (AssetTagVar),
>
> AssetTagVar
>
> );
>
> }
>
> @@ -433,9 +433,9 @@ ApplyVariables (
> * spaces. SystemMemorySizeBelow4GB tracks the maximum memory below 4GB
>
> * line, factoring in the limit imposed by the SoC register range.
>
> */
>
> - SystemMemorySizeBelow4GB = MIN(SystemMemorySize, 4UL * SIZE_1GB);
>
> - SystemMemorySizeBelow4GB = MIN(SystemMemorySizeBelow4GB, BCM2836_SOC_REGISTERS);
>
> - SystemMemorySizeBelow4GB = MIN(SystemMemorySizeBelow4GB, BCM2711_SOC_REGISTERS);
>
> + SystemMemorySizeBelow4GB = MIN (SystemMemorySize, 4UL * SIZE_1GB);
>
> + SystemMemorySizeBelow4GB = MIN (SystemMemorySizeBelow4GB, BCM2836_SOC_REGISTERS);
>
> + SystemMemorySizeBelow4GB = MIN (SystemMemorySizeBelow4GB, BCM2711_SOC_REGISTERS);
>
>
>
> ASSERT (SystemMemorySizeBelow4GB > 3UL * SIZE_1GB);
>
>
>
> @@ -528,14 +528,14 @@ ApplyVariables (
> /*
>
> * SD card pins go to Arasan.
>
> */
>
> - MmioWrite32((GPIO_BASE_ADDRESS + 0xD0),
>
> - MmioRead32(GPIO_BASE_ADDRESS + 0xD0) | 0x2);
>
> + MmioWrite32 ((GPIO_BASE_ADDRESS + 0xD0),
>
> + MmioRead32 (GPIO_BASE_ADDRESS + 0xD0) | 0x2);
>
> } else {
>
> /*
>
> * SD card pins back to eMMC2.
>
> */
>
> - MmioWrite32((GPIO_BASE_ADDRESS + 0xD0),
>
> - MmioRead32(GPIO_BASE_ADDRESS + 0xD0) & ~0x2);
>
> + MmioWrite32 ((GPIO_BASE_ADDRESS + 0xD0),
>
> + MmioRead32 (GPIO_BASE_ADDRESS + 0xD0) & ~0x2);
>
> /*
>
> * WiFi back to Arasan.
>
> */
>
Reviewed-by: Pete Batard <pete at akeo.ie>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64833): https://edk2.groups.io/g/devel/message/64833
Mute This Topic: https://groups.io/mt/76484336/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list