[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: clamav for epel looking for reviewer



On Wed, 5 Dec 2007 14:13:35 -0700
smooge gmail com ("Stephen John Smoogen") wrote:

> On Dec 5, 2007 11:31 AM, Kevin Fenzi <kevin tummy com> wrote:
> > Greetings.
> >
> > I submitted a while ago a review request for a new spec for clamav
> > in EPEL. So far I haven't gotten any reviewers interested in it...
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=396171
> >
> > If anyone would like to review it that would be great.
> >
> > I would be happy to also trade reviews.
> >
> > It would be nice to get this in so EPEL has a nice new up to date
> > and
> authorize> working clamav.
> >
> 
> Ok... my opinions aren't going to be the greatest as I am really out
> of practice.. but here are some general questions

All feedback welcome. ;) Happy to answer... 

> 1) Is massive perl patches ok for Fedora packages or is it better to
> generate the patch as a file and apply it directly. When I do it
> myself, I prefer the second as it doesnt break my auto-buildsystem as
> much as pulling in perl etc when I don't need it.

There isn't any guideline either way. I usually prefer to use patches
myself, but this spec is based on one from Dag, and he used the perl
substitutions in there, so I left it in order to keep close to his spec.
As far as I know there is no guideline prohibiting this...

> 2) file creation from inside of the SPEC. Is it better to have them as
> seperate files or use cat inside the SPEC? Again.. I prefer seperate
> files.. but I can understand having it in the spec means fix once
> versus remember to fix a file you forgot about.

Yeah, again it's a matter of taste. I don't think there is any
guideline about which way to do things. Also again, I perfer seperate
files, but am keeping it this way to stay close to the Dag spec. 

> 3) The generation of the UID is using whatever useradd gives it. Does
> this fit in with the Fedora/EPEL standards?

Yes. See: 
http://fedoraproject.org/wiki/Packaging/UsersAndGroups

The idea is that if you need a user to be a specific uid, you can
already create that user with your fixed uid. This package checks when
you install and if the user is already there it leaves it alone. If you
don't care, one is created when this package is first installed. 

kevin

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]