[et-mgmt-tools] Subject:[PATCH][RESEND] Windows HVM can't continue toinstall

[Hugh Brock]

Nobuhiro Itou wrote:
> Hi Hugh
> 
>> We don't really want to put OS-specific stuff into the virt-install code 
>> if we can help it; we made an exception for the config flag setting 
>> stuff because we're just abstracting behavior (setting acpi= and apic=) 
>> that is already available.
> 
> All right.
> In fact, I think OS-specific stuff shouldn't put into the virt-install, too.
> 
>> However I don't see any reason why a patch that would allow a virtinst 
>> argument like "--keep-cdrom" and then put something like "<disk 
>> type="block" device="cdrom">... etc" in the domain's permanent xml 
>> wouldn't work. This would mean that the domain would have access to the 
>> cdrom drive every time it reboots. Of course, it also means we'll need 
>> to provide some way to disconnect the domain from that drive once the 
>> install process is finished, but we'll get to that later.
>>
>> Let me know if that works for you...
> 
> I remaked a patch.
> This time, it has the flag in FullVirtGuest.OS_TYPES.
> The OS-specific code is removed from virt-inst.
> How about this correction?
> 
> Signed-off-by: Nobuhiro Itou <fj0873gn at aa.jp.fujitsu.com>
> 
> 
> Thanks,
> Nobuhiro Itou.
> 

OK, I have applied this. It seems to work fine with Win2k, but I don't 
have XP install CDs, so I can't tell if it works or not with XP or 
Server 2003. Please test it and let me know!

And Thanks!, as always...

Take care,
--Hugh

-- 
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org