[et-mgmt-tools] [PATCH] Rework virtinst device lists for install

[Daniel P. Berrange]

On Wed, Nov 07, 2007 at 05:24:14PM -0500, Cole Robinson wrote:
> The following patch changes around how the 'disks' and 'nics' lists in a
> Guest object are used during an install.
> 
> These lists are the public attributes used to specify the devices to
> connect to the guest at install time. Currently, during the actual
> install, these lists can be manipulated by the installer, to add a
> boot.iso as a CDROM disk to use for the install, for example ('nics'
> actually isn't altered during any install path but I wanted to be
> consistent.) This causes issues if the install fails, but the Guest object
> is kept around to try again (i.e. virt-manager): any re-attempt would
> append another cdrom disk based off the boot.iso.
> 
> Rather than have an error cleanup restore things to their post install
> state, which would probably cause this bug to pop up again if another
> error path was added, I went with a small reorg which seems to be the
> right way to fix this. 'disks' and 'nics' remain but they are copied over
> to private lists at the start of the install to be used for all
> mid-install disk/nic additions. The public interface remains the same, its
> just behind the scenes workings that are shuffled.

ACK, looks good to me.


Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|