[et-mgmt-tools] [PATCH] virtinst: add storage builders for logical pools and volumes

Daniel P. Berrange berrange at redhat.com
Wed Aug 13 10:56:05 UTC 2008


On Tue, Aug 12, 2008 at 08:21:15PM -0400, Cole Robinson wrote:
> The attached patch adds virtinst support for building
> logical pools and volumes. Sort of. This will allow
> creating new volumes, but not creating pools (aka
> volume groups) from a specified set of physical disks.
> I believe libvirt supports this, but I haven't tried it
> yet.

Not a huge issue - using a pre-existing volume group is by
far the most important use case here.

> However this does allow the user to point at an existing
> lvm volume group and have it recognized as a storage pool
> which will be by far the common case. The nice thing
> about this is that it will all become immediately available
> in the virt-manager UI (posted previously).

Looks good.

> One thing I've encountered with this though: does a volume's
> target path have any significance upon creation? File volumes
> just seem to create a file based on the passed 'name', not
> target path. Disk volumes ignore both when creating. Logical
> vols also only use the name, but try to validate the target
> path after creation, which we shouldn't need passed (the result
> should simply be vgpath + "/" + volname). So it seems like
> target path has no real meaning when defining a volume. Am
> I missing something?

That is correct - the target path for a volume is filled in
according to the policy of the storage pool, often based off
the name of the storage volume + the target path of the 
storage pool

Daniel

-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the et-mgmt-tools mailing list