[et-mgmt-tools] [PATCH] virt-install cli options for managed storage

[Cole Robinson]

Daniel P. Berrange wrote:
> On Thu, Aug 14, 2008 at 12:28:24PM -0400, Cole Robinson wrote:
>> Cole Robinson wrote:
>>> Per Dan's advice, I've changed the previously proposed
>>> virt-install cli options for specifying libvirt managed
>>> storage.
>>>
>>> This patch does not change any possible semantics of
>>> --file or --cdrom: they remain strictly for specifying
>>> local media. In this way they are basically deprecated.
>>>
>> Here's the second cut. Format for the cli options is
>>
>> --disk path=/some/path[,device=cdrom|floppy][,permissions=ro|sh]
>> --disk pool=poolname[,device=cdrom|floppy][,permissions=ro|sh]
>> --disk vol=poolname/volname[,device=cdrom|floppy][,permissions=ro|sh]
>>
>> Hopefully this will simplify things and fix the issues encountered.
> 
> Ok, this looks good to me now, though shorten 'permissions' to 'perms'
> because I'm lazy typing.
> 
> Daniel

Thanks, I've committed this with the suggested 'perms' fix:

http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=354ea4aa8fda

- Cole