[et-mgmt-tools] [PATCH 01 of 11] Fix multiple disks

[John Levon]

On Tue, Jul 08, 2008 at 01:14:46PM +0100, Daniel P. Berrange wrote:

> > Signed-off-by: John Levon <john.levon at sun.com>
> > 
> > diff --git a/virtconv/parsers/virtimage.py b/virtconv/parsers/virtimage.py
> > --- a/virtconv/parsers/virtimage.py
> > +++ b/virtconv/parsers/virtimage.py
> > @@ -117,12 +117,12 @@ class virtimage_parser(vmconfig.parser):
> >  
> >              # FIXME: needs updating for later Xen enhancements; need to
> >              # implement capabilities checking for max disks etc.
> > -            pv_disks.append("""<drive disk="%s" target="xvd%s" />""" %
> > +            pv_disks.append("""<drive disk="%s" target="xvd%s" />\n""" %
> >                  (path, ascii_letters[number % 26]))
> > -            hvm_disks.append("""<drive disk="%s" target="hd%s" />""" %
> > +            hvm_disks.append("""<drive disk="%s" target="hd%s" />\n""" %
> >                  (path, ascii_letters[number % 26]))
> 
> IDE only allows upto 4 disks. To allow more than this requires use of
> SCSI or VirtIO/Xen paravirt drivers.

A later patch fixes this up somewhat, though this part is just a small
fix to existing code.

> I'd probably say default to IDE for first 4, and then switch to sdNNN
> for any subsequent disks. 

Xen doesn't seem to be able to handle sd* meaningfully, at least.

regards
john