[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [patch] virt-convert - disk signature support - patch 1



Did some more testing and made some syntax changes, should work now



Joey Boggs wrote:
Corrected spacing and removed md5


Cole Robinson wrote:
Daniel P. Berrange wrote:
On Wed, Oct 08, 2008 at 12:22:05PM -0400, Joey Boggs wrote:
This adds the underlying support for disk signatures into virt-convert disk class for each disk. Additional changes to follow in completing implementation
There's not much point in doing md5 and sha1, both are more or
less equivalent strength and compromised algorithms. Doing both
is just wasting CPU resources. Pick either md5 or sha1 for sake
of compatability with old python, and then sha256 for strength.


OVF seems to offer sha-1 hashes for packaged files, so let's
use that and sha256.
diff -r 2aba69a1a16c virtconv/diskcfg.py
--- a/virtconv/diskcfg.py    Mon Oct 06 12:21:17 2008 -0400
+++ b/virtconv/diskcfg.py    Wed Oct 08 12:19:19 2008 -0400
@@ -53,6 +53,11 @@
     "vdisk": DISK_FORMAT_VDISK,
 }
+checksum_types = {
+    CSUM_MD5 = 'md5'
+    CSUM_SHA1 = 'sha1'
+    CSUM_SHA256 = 'sha256'
+}

Stick a new line after this to preserve the previous spacing.

 def ensuredirs(path):
     """
     Make sure that all the containing directories of the given file
@@ -83,6 +88,7 @@
         self.bus = bus
         self.type = type
         self.clean = []
+        self.csum_dict = {}
def cleanup(self):
         """

Thanks,
Cole

------------------------------------------------------------------------

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools redhat com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

diff -r 2aba69a1a16c virtconv/diskcfg.py
--- a/virtconv/diskcfg.py	Mon Oct 06 12:21:17 2008 -0400
+++ b/virtconv/diskcfg.py	Thu Oct 09 10:51:50 2008 -0400
@@ -34,6 +34,9 @@
 DISK_TYPE_CDROM = 1
 DISK_TYPE_ISO = 2
 
+CSUM_SHA1 = 0
+CSUM_SHA256 = 1
+
 disk_suffixes = {
     DISK_FORMAT_RAW: ".raw",
     DISK_FORMAT_VMDK: ".vmdk",
@@ -51,6 +54,11 @@
     "raw": DISK_FORMAT_RAW,
     "vmdk": DISK_FORMAT_VMDK,
     "vdisk": DISK_FORMAT_VDISK,
+}
+
+checksum_types = {
+    CSUM_SHA1 : "sha1",
+    CSUM_SHA256 : "sha256",
 }
 
 def ensuredirs(path):
@@ -83,6 +91,7 @@
         self.bus = bus
         self.type = type
         self.clean = []
+        self.csum_dict = {}
 
     def cleanup(self):
         """

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]