[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] virt-install: use --disk to specify size and sparse



On Fri, Sep 05, 2008 at 10:16:28AM -0400, Cole Robinson wrote:
> The attached patch expands the options that can be
> lumped onto virt-install's new --disk option to
> specify size of new storage, and whether we want to
> create it as sparse.
> 
> The format for these options is:
> 
>   --disk path=/some/new/file,size=5,sparse=true|false
> 
> This acts similar to the current options: if the file
> doesn't exist, size is required, and we default to
> sparse=True if it isn't specified.
> 
> This effectively deprecates --file, --file-size, and
> --nonsparse, and in my opinion is much simpler. It also
> helps overcome some problems we had with the original
> options for cases of specifying multiple disks: there
> was no way to specify one sparse disk and one nonsparse
> disk, and generally specifying multiple disks was
> unclear and a pain.
> 
> I also added a manpage section for the --disk option.

Great - this all looks good to me.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]