[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] virt-install: use --disk to specify size and sparse



Daniel P. Berrange wrote:
> On Fri, Sep 05, 2008 at 10:16:28AM -0400, Cole Robinson wrote:
>> The attached patch expands the options that can be
>> lumped onto virt-install's new --disk option to
>> specify size of new storage, and whether we want to
>> create it as sparse.
>>
>> The format for these options is:
>>
>>   --disk path=/some/new/file,size=5,sparse=true|false
>>
>> This acts similar to the current options: if the file
>> doesn't exist, size is required, and we default to
>> sparse=True if it isn't specified.
>>
>> This effectively deprecates --file, --file-size, and
>> --nonsparse, and in my opinion is much simpler. It also
>> helps overcome some problems we had with the original
>> options for cases of specifying multiple disks: there
>> was no way to specify one sparse disk and one nonsparse
>> disk, and generally specifying multiple disks was
>> unclear and a pain.
>>
>> I also added a manpage section for the --disk option.
> 
> Great - this all looks good to me.
> 
> Daniel

Thanks, I've committed this:

http://hg.et.redhat.com/virt/applications/virtinst--devel

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]