[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] virtinst - virt-convert vmware output



On Mon, Sep 22, 2008 at 05:16:16PM -0400, Cole Robinson wrote:
> Joey Boggs wrote:
> > This will replace the virt-pack command and supplemental Unware.py file 
> > and integrate them into virt-convert directly as a module.
> > 
> > I'll create a patch to remove the deprecated files once tested by others.
> > 
> > Other notes, only supports raw disks, adding in qcow support should be 
> > fairly easy, just wanted to get this out the door first.
> > 
> > 
> 
> > diff -r f87154697807 virt-convert
> > --- a/virt-convert	Thu Sep 18 16:44:30 2008 -0400
> > +++ b/virt-convert	Mon Sep 22 12:17:55 2008 -0400
> > @@ -49,8 +49,7 @@
> >      opts.add_option("-i", "--input-format", action="store",
> >                      dest="input_format", help=("Input format, e.g. 'vmx'"))
> >      opts.add_option("-o", "--output-format", action="store",
> > -                    dest="output_format", default="virt-image",
> > -                    help=("Output format, e.g. 'virt-image'"))
> > +                    dest="output_format", help=("Output format, e.g. 'virt-image / vmware'"))
> 
> Since we are using 'vmx' as an input format type, we
> should probably also use it as the name of the output
> format (not 'vmware').

Yes that's a good idea - you never know if vmware will introduce a new
non-vmx format, so using 'vmx' makes it clearer which we're talking about.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]