[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: NEEDS_RECOVERY flag



Hi,

On Mon, Nov 20, 2000 at 09:10:26AM -0800, Peter J. Braam wrote:
> 
> I tried Andreas' patch (attached)  and it works great. 

Just applying it to 0.0.5c.  A few problems:

> +		desc_blocks = ext3_bg_num_gdb(sb, i);
> +		for (j = 0; j < ext3_bg_num_gdb(sb, i); j++)
				^^^^^^^^^^^^^^^
should be desc_blocks (trivial optimisation).

> -			sb->u.ext3_sb.s_es->s_feature_ro_compat |=
> -				cpu_to_le32(EXT3_FEATURE_RO_COMPAT_LARGE_FILE);
> +			ext3_update_fs_rev(sb);
> +			EXT3_SET_INCOMPAT_FEATURE(sb,
				 ^^^^^^^^

should be RO_COMPAT.

> +			if (!EXT3_HAS_INCOMPAT_FEATURE(sb,
> +					EXT3_FEATURE_RO_COMPAT_LARGE_FILE)) {

Same problem.

Otherwise, all applied.

Cheers,
 Stephen





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]