[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: ext3+acl



Yup.  Believe I've found the culprit, this also explains why I felt it did
*indeed* work for me in the past.  (It did at one time).  :)

Basically, I've had LFS in my kernel for some time.. and in the ext3+lfs
patch you'll note in fs/ext3/inode.c there is a change along the lines of:

	/* Notify-change transaction.  The maximum number of buffers
-	 * required is one. */
+	 * required is two. (inode and superblock if a largefile). */

-	handle = ext3_journal_start(inode, 1);
+	handle = ext3_journal_start(inode, 2);

At one point Andreas and I had a little offline discussion and comparison
of LFS patches.  In the end, I ended up reworking mine and bit and was
still using handle=ext3_journal_start(inode,1);.  So, I've changed my code
to use handle=ext3_journal_start(inode,2); and it does indeed seem to
survive the misc.test for at least half an hour now so far.  It'd normally
fall down pretty quick.

I'm cc'ing the ext3 list also as I get the feeling this is still an issue
in stock ext3-0.0.7a patch as you've stated it works for you after
applying the LFS patch.

Stephen may not be aware and better yet, maybe we're just masking the
issue in our case.  The assertion it would generate prior was
h->buffer_credits > 0 or such.

On Fri, 15 Jun 2001, Eric Jarman wrote:

> Date: Fri, 15 Jun 2001 13:01:52 -0500 (CDT)
> From: Eric Jarman <ehj38230 cmsu2 cmsu edu>
> To: Jay Weber <jweber valinux com>
> Subject: Re: ext3+acl
>
> I'm not sure what fixed it.  It went away when I added the LFS patches on top of
> ext3 0.0.7a, but is still there without LFS.  This has me thinking it might have
> been a subtle bug somewhere in ext3 itself.
>
> Quoting Jay Weber <jweber valinux com>:
>
> > Can I ask what changed to get past the last bug you hit?  The one along
> > the lines of handle_credit > 0 or whatever the message was.
> >
> > Just curious if you tracked it down or if it just went away with the
> > latest ext3 0.0.7a.
> >
> >
> > On Fri, 15 Jun 2001, Eric Jarman wrote:
> >
> > > Date: Fri, 15 Jun 2001 10:47:28 -0500 (CDT)
> > > From: Eric Jarman <ehj38230 cmsu2 cmsu edu>
> > > Reply-To: ext3-users redhat com
> > > To: acl-devel bestbits at
> > > Cc: ext3-users redhat com
> > > Subject: ext3+acl
> > >
> > > A patch that implements acls on ext3 for kernel 2.2.x is available at
> > > http://moldybread.net/patch/kernel-2.2/
> > >
> > > It looks to be stable.  Beat it, break it.
> > >
> > >
> > >
> > > _______________________________________________
> > > Ext3-users mailing list
> > > Ext3-users redhat com
> > > https://listman.redhat.com/mailman/listinfo/ext3-users
> > >
> >
>
>
> -------------------------------------------------
> This mail sent through MuleMail: http://mulemail.cmsu.edu/
>






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]