[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: ext3_rename ctime handling



On Mon, Mar 19, 2001 at 10:56:50PM -0800, Peter J. Braam wrote:
> Hi, 
> 
> Arthur found out that ext3 is not changing the ctime on the "old_dir" (the
> object that is being renamed), but ext2 does.  It looks to me like this is
> simply an omission of the following little patch from namei.c
> 
> - Peter -
> 
> 
> --- fs/ext3/namei.c.orig        Mon Mar 19 22:55:03 2001
> +++ fs/ext3/namei.c     Mon Mar 19 22:53:40 2001
> @@ -985,6 +985,13 @@
>          new_dir->i_version = ++global_event;
>  
>          /*
> +         * Like most other Unix systems, set the ctime for inodes on a
> +         * rename.
> +         */
> +        old_inode->i_ctime = CURRENT_TIME;
> +        ext3_mark_inode_dirty(old_inode);
> +
> +        /*
>           * ok, that's it
>           */
>  
> 
> 
> -- 

Looks like that ought to be

           ext3_mark_inode_dirty(handle,old_inode);

Regards,

    Bill Rugolsky





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]