[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: how to counteract slowdown



Neil Brown wrote:
> 
> On Monday November 12, akpm zip com au wrote:
> > > Under heavy NFS load, I get pauses of a few seconds every few minutes.
> > > If I
> > >    echo 40 0 0 0 60 300 60 0 0 > /proc/sys/vm/bdflush
> > >
> > > the problem goes away.
> >
> > So how long have you been sitting on this info, you, you,
> > you Australian, you?
> >
> 
> Ever since
>    Date: Thu, 12 Jul 2001 21:51:36 +1000 (EST)
> when I first told you about it.... (non-list email to You, Stephen and
> Andreas).

Oh.  I thought we resolved that one.

>
> (*) by "empty" I mean that all transactions in the journal have been
> committed to non-journal storage.  Not that there aren't any
> transactions in the journal.
> 

Did we try starting writeback on checkpoint data immediately?

--- linux-2.4.15-pre4/fs/jbd/commit.c	Mon Nov 12 11:16:12 2001
+++ linux-akpm/fs/jbd/commit.c	Mon Nov 12 19:30:53 2001
@@ -649,7 +649,10 @@ skip_commit:
 			JBUFFER_TRACE(jh, "add to new checkpointing trans");
 			__journal_insert_checkpoint(jh, commit_transaction);
 			JBUFFER_TRACE(jh, "refile for checkpoint writeback");
+			get_bh(bh);
 			__journal_refile_buffer(jh);
+			ll_rw_block(WRITE, 1, &bh);
+			put_bh(bh);
 		} else {
 			J_ASSERT_BH(bh, !buffer_dirty(bh));
 			J_ASSERT_JH(jh, jh->b_next_transaction == NULL);





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]