[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

unsubscribe



On Friday, December 6, 2002, at 12:02 PM, ext3-users-request redhat com wrote:

Send Ext3-users mailing list submissions to
	ext3-users redhat com

To subscribe or unsubscribe via the World Wide Web, visit
	https://listman.redhat.com/mailman/listinfo/ext3-users
or, via email, send a message with subject or body 'help' to
	ext3-users-request redhat com

You can reach the person managing the list at
	ext3-users-admin redhat com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Ext3-users digest..."

Today's Topics:

1. Re: ext3-Partition lost after crash !? (Stephan Wiehr)
2. [patch] fix the ext3 data=journal unmount bug (Andrew Morton)
Message: 1
Return-Path: <mail redhat com>
Delivered-To: ext3-users listman redhat com
Date: Thu, 5 Dec 2002 18:02:22 +0100
From: Stephan Wiehr <lynx asta uni-sb de>
To: ext3-users redhat com
Subject: Re: ext3-Partition lost after crash !?
Message-ID: <20021205170222 GA6361 asta05 asta uni-sb de>
Mail-Followup-To: Stephan Wiehr <lynx>, ext3-users redhat com
References: <20021204131428 GA19212 asta05 asta uni-sb de> <20021204150052 GE22551 think thunk org> <20021205070249 GA24437 asta05 asta uni-sb de> <20021205132224 GA8203 think thunk org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021205132224 GA8203 think thunk org>
User-Agent: Mutt/1.3.28i
Sender: ext3-users-admin redhat com
Precedence: bulk
List-Help: <mailto:ext3-users-request redhat com?subject=help>
List-Post: <mailto:ext3-users redhat com>
List-Subscribe: <https://listman.redhat.com/mailman/listinfo/ext3-users>,
<mailto:ext3-users-request redhat com?subject=subscribe>
List-Id: EXT3 Users Mailing List <ext3-users.redhat.com>
List-Unsubscribe: <https://listman.redhat.com/mailman/listinfo/ext3-users>,
<mailto:ext3-users-request redhat com?subject=unsubscribe>
List-Archive: <https://listman.redhat.com/pipermail/ext3-users/>


On Thu, Dec 05, 2002 at 08:22:25AM -0500, Theodore Ts'o wrote:
The workaround is relatively simple; use debugfs to clear the
journal_inum field, via the command "set_super_value journal_inum 0",
and then e2fsck will stop blowing out due to the bad journal inode.

This worked well, after fsck I had all top directories in lost+found so I
could simply move the dirs to their original places. I have to look how much
data was lost but so far the most important data is safe. Many thanks!


It might be worth examining some other inode numbers to see how
extensive is the damage.  Each inode is 128 bytes long, and IDE disk
sectors are 512 bytes, so if you're really lucky, only 4 consecutive
inodes will be damaged.  However, it's much more likely that at least
a filesystem block's worth (4096 bytes, or 32 inodes) were lost, and
if you're really unlucky, it may be a lot more than that.

It seems it was 32 inodes - at least I hat to 'y' 32 times to 'illegal inode'.


Also worth considering before you do anything is the cause of the
corruption.  It could have been caused by the controller or the IDE
disk going temporarily insane, in which case hopefully it won't be
repeated, but if it is repeatable, doing an image backup will probably
be a good idea.

I'm quite sure that the cause for the fs-corruption is some kind of
connection-failure, since I had problems with this disk as removable disk
only (maybe some loose contact in the removable drawer). There were problems
with the system (which is on the primary IDE master) running normally with
all 4 partitions of this disk (the primary IDE slave) suddenly being gone
although mount still knew about these...
After all now it's fixed normally like it should be...also the other
partitions on that disk are all ok.


Good luck!!

Seems this is what I had. Many thanks again for your help!


Best regards
--
        Stephan Wiehr
http://www.asta.uni-sb.de/~lynx/
"Always remember: You're unique,
        just like everyone else."



Message: 2
Return-Path: <mail redhat com>
Delivered-To: ext3-users listman redhat com
Message-ID: <3DF03B35 AA5858DC digeo com>
Date: Thu, 05 Dec 2002 21:52:53 -0800
From: Andrew Morton <akpm digeo com>
MIME-Version: 1.0
To: lkml <linux-kernel vger kernel org>,
"ext3-users redhat com" <ext3-users redhat com>
Subject: [patch] fix the ext3 data=journal unmount bug
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: ext3-users-admin redhat com
Precedence: bulk
List-Help: <mailto:ext3-users-request redhat com?subject=help>
List-Post: <mailto:ext3-users redhat com>
List-Subscribe: <https://listman.redhat.com/mailman/listinfo/ext3-users>,
<mailto:ext3-users-request redhat com?subject=subscribe>
List-Id: EXT3 Users Mailing List <ext3-users.redhat.com>
List-Unsubscribe: <https://listman.redhat.com/mailman/listinfo/ext3-users>,
<mailto:ext3-users-request redhat com?subject=unsubscribe>
List-Archive: <https://listman.redhat.com/pipermail/ext3-users/>




This patch fixes the data loss which can occur when unmounting a
data=journal ext3 filesystem.

The core problem is that the VFS doesn't tell the filesystem enough
about what is happening.  ext3 _needs_ to know the difference between
regular memory-cleansing writeback and sync-for-data-integrity
purposes.

(These two operations are really quite distinct, and the kernel has got
it wrong for ages.  Even now, kupdate is running filemap_fdatawait()
quite needlessly)

In the early days, ext3 would assume that a write_super() call meant
"sync".  That worked OK.

But that slowed down the kupdate function - it doesn't need to wait on
the writeout.  So we took the `wait' out of ext3_write_super().  And
that worked OK too, because the VFS would later write back all the
dirty data for us.

But then an unrelated optimisation to the truncate path caused that to
not work any more, and we were exposed.



This patch adds a new super_block operation `sync_fs', whose mandate is
to "sync the filesystem" for data-integrity purposes.  ie: it is a
synchronous writeout, whereas write_super is an asynchronous flush.

It is a minimal fix.  Really all the `sync' code in the VFS needs a
rethink.  It is _very_ ext2-centric, and needs to be redesigned to
provide more information to sophisticated filesystems about what is
going on.

But that's not a 2.4 project.  And it's not looking like a 2.5 project
either - I shall be proposing the same fix for 2.5.



 fs/buffer.c        |    6 ++++--
 fs/ext3/super.c    |   25 +++++++++++++------------
 fs/super.c         |    6 +++++-
 include/linux/fs.h |    3 ++-
 4 files changed, 24 insertions(+), 16 deletions(-)

--- linux-akpm/fs/buffer.c~sync_fs	Thu Dec  5 21:33:56 2002
+++ linux-akpm-akpm/fs/buffer.c	Thu Dec  5 21:33:56 2002
@@ -327,6 +327,8 @@ int fsync_super(struct super_block *sb)
 	lock_super(sb);
 	if (sb->s_dirt && sb->s_op && sb->s_op->write_super)
 		sb->s_op->write_super(sb);
+	if (sb->s_op && sb->s_op->sync_fs)
+		sb->s_op->sync_fs(sb);
 	unlock_super(sb);
 	unlock_kernel();

@@ -346,7 +348,7 @@ int fsync_dev(kdev_t dev)
 	lock_kernel();
 	sync_inodes(dev);
 	DQUOT_SYNC(dev);
-	sync_supers(dev);
+	sync_supers(dev, 1);
 	unlock_kernel();

 	return sync_buffers(dev, 1);
@@ -2833,7 +2835,7 @@ static int sync_old_buffers(void)
 {
 	lock_kernel();
 	sync_unlocked_inodes();
-	sync_supers(0);
+	sync_supers(0, 0);
 	unlock_kernel();

 	for (;;) {
--- linux-akpm/include/linux/fs.h~sync_fs	Thu Dec  5 21:33:56 2002
+++ linux-akpm-akpm/include/linux/fs.h	Thu Dec  5 21:33:56 2002
@@ -894,6 +894,7 @@ struct super_operations {
 	void (*delete_inode) (struct inode *);
 	void (*put_super) (struct super_block *);
 	void (*write_super) (struct super_block *);
+	int (*sync_fs) (struct super_block *);
 	void (*write_super_lockfs) (struct super_block *);
 	void (*unlockfs) (struct super_block *);
 	int (*statfs) (struct super_block *, struct statfs *);
@@ -1240,7 +1241,7 @@ static inline int fsync_inode_data_buffe
 extern int inode_has_buffers(struct inode *);
 extern int filemap_fdatasync(struct address_space *);
 extern int filemap_fdatawait(struct address_space *);
-extern void sync_supers(kdev_t);
+extern void sync_supers(kdev_t dev, int wait);
 extern int bmap(struct inode *, int);
 extern int notify_change(struct dentry *, struct iattr *);
 extern int permission(struct inode *, int);
--- linux-akpm/fs/super.c~sync_fs	Thu Dec  5 21:33:56 2002
+++ linux-akpm-akpm/fs/super.c	Thu Dec  5 21:33:56 2002
@@ -445,7 +445,7 @@ static inline void write_super(struct su
  * hold up the sync while mounting a device. (The newly
  * mounted device won't need syncing.)
  */
-void sync_supers(kdev_t dev)
+void sync_supers(kdev_t dev, int wait)
 {
 	struct super_block * sb;

@@ -454,6 +454,8 @@ void sync_supers(kdev_t dev)
 		if (sb) {
 			if (sb->s_dirt)
 				write_super(sb);
+			if (wait && sb->s_op && sb->s_op->sync_fs)
+				sb->s_op->sync_fs(sb);
 			drop_super(sb);
 		}
 		return;
@@ -467,6 +469,8 @@ restart:
 			spin_unlock(&sb_lock);
 			down_read(&sb->s_umount);
 			write_super(sb);
+			if (wait && sb->s_op && sb->s_op->sync_fs)
+				sb->s_op->sync_fs(sb);
 			drop_super(sb);
 			goto restart;
 		} else
--- linux-akpm/fs/ext3/super.c~sync_fs	Thu Dec  5 21:33:56 2002
+++ linux-akpm-akpm/fs/ext3/super.c	Thu Dec  5 21:33:56 2002
@@ -47,6 +47,8 @@ static void ext3_mark_recovery_complete(
 static void ext3_clear_journal_err(struct super_block * sb,
 				   struct ext3_super_block * es);

+static int ext3_sync_fs(struct super_block * sb);
+
 #ifdef CONFIG_JBD_DEBUG
 int journal_no_write[2];

@@ -454,6 +456,7 @@ static struct super_operations ext3_sops
delete_inode: ext3_delete_inode, /* BKL not held. We take it */
put_super: ext3_put_super, /* BKL held */
write_super: ext3_write_super, /* BKL held */
+ sync_fs: ext3_sync_fs,
write_super_lockfs: ext3_write_super_lockfs, /* BKL not held. Take it */
unlockfs: ext3_unlockfs, /* BKL not held. We take it */
statfs: ext3_statfs, /* BKL held */
@@ -1577,24 +1580,22 @@ int ext3_force_commit(struct super_block
* This implicitly triggers the writebehind on sync().
*/


-static int do_sync_supers = 0;
-MODULE_PARM(do_sync_supers, "i");
-MODULE_PARM_DESC(do_sync_supers, "Write superblocks synchronously");
-
 void ext3_write_super (struct super_block * sb)
 {
+	if (down_trylock(&sb->s_lock) == 0)
+		BUG();
+	sb->s_dirt = 0;
+	log_start_commit(EXT3_SB(sb)->s_journal, NULL);
+}
+
+static int ext3_sync_fs(struct super_block *sb)
+{
 	tid_t target;
 	
-	if (down_trylock(&sb->s_lock) == 0)
-		BUG();		/* aviro detector */
 	sb->s_dirt = 0;
 	target = log_start_commit(EXT3_SB(sb)->s_journal, NULL);
-
-	if (do_sync_supers) {
-		unlock_super(sb);
-		log_wait_commit(EXT3_SB(sb)->s_journal, target);
-		lock_super(sb);
-	}
+	log_wait_commit(EXT3_SB(sb)->s_journal, target);
+	return 0;
 }

/*

_





_______________________________________________
Ext3-users mailing list
Ext3-users redhat com
https://listman.redhat.com/mailman/listinfo/ext3-users






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]