[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [fedora-arm] [PATCH] libidn: Fix problem with #include_next



On Mon, Dec 29, 2008 at 04:18:55PM +0530, Kedar Sovani wrote:

> > > #include_next is not understood by the compiler, and hence it gives up. 
> > > 
> > > (I don't understand why this is not seen in x86 builds, comments?)
> > 
> > Probably because the binary package in the archive was built with
> > some older gcc version, or something like that.  Try rebuilding the
> > package on x86 on a fully updated root fs and see if it still happens?
> > 
> > 
> > >  %prep
> > >  %setup -q
> > >  %patch0 -p1 -b .aconf262
> > > +%ifarch %{arm}
> > > +%patch1 -p1 -b .include-next-fix
> > > +%endif
> > 
> > Don't make patches dependent on the build environment (I think there
> > is a rule forbidding doing what you're doing here).
> 
> The patch has appeared upstream at the libidn project (31 Aug 2007):
> 
> http://git.savannah.gnu.org/gitweb/?p=libidn.git;a=commitdiff;h=12f2443a37b9e6c95022e503f7853bd02110865e;hp=d39d8bd1e12c81a0795ad6f55ceb930a8f7662c2
> 
> It seems the Fedora libidn has been using version 0.6.14, while upstream
> has moved to version 1.0, about 16 months ago.

What I mean is, just include it unconditionally (i.e. not dependent
on %{arm})?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]