[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Echo] New image-missing icon set



Martin Sourada a écrit :
> I've slightly changed the 22x22 version of the paper template to be more
> consistent with the other variants (basically I made it 1 pixel
> shorter), you should update the image-missing too (the change is small
> but makes it look better). When done I have no further comments. Don't
> forget to hide the plate layer before commit (in the template SVG it is
> displayed intentionally) ;-)
>
>   
Done.
> I also created a script for checking if the icon is ready for commit. I
> attach it. Just extract it somewhere, cd to the echo-icon-check
> directory and use it: echo-icon-check <path-to-icon-svg>. It should
> detect all most obvious problems (and some of them prints as warnings,
> the fatal ones as errors).
>   
I have tested that script. It does its job. I think you should add quote
like "Done. No error reported".
>
> I appreciate feedback on it so that when its released officially, it
> would be a really helpful utility. You can try to run it on the
> paper-template I attached to see that it prints an error that plate
> layer is not hidden and when you hide it it still complains about
> missing group labelled scalable, which is OK for a template, but not for
> an icon. ;-) I hope the printed errors are worded good enough...
>   
Speaking about paper-template, it will be nice to set a directory to
store such template in git repository.

Luya

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]