New version of mock working (I think)

Oliver Falk oliver at linux-kernel.at
Wed Jun 21 19:54:20 UTC 2006


Clark Williams wrote:
>> Thx for letting us know about your progress, Clark!
>>
>> Best would be you send a patch/diff to the list - first of all, so
>> all can investigate... At least I would appreciate!
> 
> 
> Good point. Attached is a 'cvs diff" of my tree, plus the new source
> file src/mock.c
> 
> Comments welcome.

I shouldn't worry about it in this context, but...


[ ... ]

> --- Makefile	12 Apr 2006 14:23:17 -0000	1.8
> +++ Makefile	21 Jun 2006 19:35:35 -0000
> @@ -21,7 +21,7 @@
>  install:
>  	mkdir -p $(DESTDIR)/usr/bin/
>  	mkdir -p $(DESTDIR)/usr/libexec
> -	install -m 755 mock.py $(DESTDIR)/usr/bin/mock
> +	install -m 755 mock.py $(DESTDIR)/usr/bin
>  	install -m 755 mock-yum $(DESTDIR)/usr/libexec/mock-yum
>  	mkdir -p $(DESTDIR)/var/lib/mock

Better written as:
install:
	install -D -m755 mock.py $(DESTDIR)/usr/bin/mock.py
         install -D -m755 mock-yum $(DESTDIR)/usr/libexec/mock-yum
         install -d -m775 $(DESTDIR)/var/lib/mock

This saves some bytes :-)

However, I really should worry 'bout other things in the world...

-of




More information about the Fedora-buildsys-list mailing list