[PATCH - RFC] config unify patch

Michael E Brown Michael_E_Brown at dell.com
Tue May 23 05:14:10 UTC 2006


	Here is a patch for discussion. It is similar to the patch sent last
week, with the exception that I have added two condition checks that
ensure the behaviour is the same with this patch as without. Net
reduction in code size is 4 lines, but it also moves all the config file
parsing to one loop.
	My belief is that either one of the two condition checks are not
necessary. IMO, the condition check prior to the config parsing loop
where it checks for file existence can be removed. We will then rely on
the check after config parsing which tests for config_opts['root'] to
ensure a proper config is given.
	Patch is for discussion. I can send an updated version after decisions
are made.
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mock-cfgunify.patch
Type: text/x-patch
Size: 2638 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20060523/83a4b393/attachment.bin>


More information about the Fedora-buildsys-list mailing list