PATCH: job.die fix for plague-0.5.0

[Dan Williams]

On Fri, 2006-10-27 at 01:11 -0400, Joe Todaro wrote:
> 
> Hi, 
> 
> Has anyone ever seen this error before in their *plague-0.5.0* build
> environment?   This is error two of three, which I mentioned in my
> previous post.   It too surfaced last week shortly after we started
> stress-testing our buildsystem.   There were three such errors in all,
> which I've posted separately to avoid any confusion.   This particular
> error seemed to trigger when we attempted to kill a job we didn't know
> had already failed the depsolve stage. 

Committed to HEAD, thanks!

Dan

> ====== THE ERROR ====== 
> 146 (cfengine): Requesting depsolve... 
> 146 (cfengine): Starting depsolve for arches: ['x86_64', 'i386',
> 'i686']. 
> Cannot open/read repomd.xml file for repository: plague 
> failure: repodata/repomd.xml from plague: [Errno 256] No more mirrors
> to try. 
> 146 (cfengine/x86_64): Depsolve Error: failure: repodata/repomd.xml
> from plague: [Errno 256] No more mirrors to try. 
> 146 (cfengine): Finished depsolve (unsuccessful), trying again later. 
> 145 (cfengine): Job kill request from jtodaro at pok.ibm.com 
> 145 (cfengine): Build on target oc-rhel4-rel was killed by
> jtodaro at pok.ibm.com. 
> Exception in thread PackageJob: 145/cfengine: 
> Traceback (most recent call last): 
>   File "/usr/lib64/python2.3/threading.py", line 436, in __bootstrap 
>     self.run() 
>   File "/usr/share/plague/server/PackageJob.py", line 86, in run 
>     self._pkg_job.process() 
>   File "/usr/share/plague/server/PackageJob.py", line 745, in process 
>     self._handle_death() 
>   File "/usr/share/plague/server/PackageJob.py", line 725, in
> _handle_death 
>     self._kill_all_archjobs(True) 
>   File "/usr/share/plague/server/PackageJob.py", line 737, in
> _kill_all_archjobs 
>     job.die(user_requested) 
> AttributeError: 'NoneType' object has no attribute 'die' 
> 
> ====== OUR FIX ======  
> We added lines 710-711 to the *_kill_all_archjobs* method of the
> */usr/share/plague/server/PackageJob.py * module.   Here's the patch: 
> 
> 
> So, can someone please review the above fix.. Again, we just want to
> make sure that it won't come back to *bite* us later on / or possibly
> even be *masking* a larger problem.   Thank you. 
> 
> -Joe 
> --
> Fedora-buildsys-list mailing list
> Fedora-buildsys-list at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-buildsys-list