mock rfe - buildgroup

[Michael E Brown]

On Fri, Jul 06, 2007 at 02:26:42PM -0500, Michael E Brown wrote:
> On Thu, Jul 05, 2007 at 08:13:17PM -0400, Jesse Keating wrote:
> > On Thursday 05 July 2007 18:21:38 Michael E Brown wrote:
> > >     http://people.redhat.com/jkeating/git/mock-nogrouprepo.git
> > >     I can probably review/push these, but it wont be until probably
> > > tomorrow.
> > >     Thoughts?
> 
> Jesse,
> 
> Looking through your patch:
> 
> +++ b/etc/defaults.cfg
> +config_opts['chroot_setup_cmd'] = 'groupinstall buildsys-build'


> 
> This could be problematic for F7, F6, EPEL4/5 and others.
> 
> I see two (three?) ways to handle this:
> 
> 1) only add this line to -devel.
> 
> 2) change the default in mock.py, and override F7/F6/EPEL4/EPEL5
> configs.
> 
> 3) add this line to -devel, and then migrate it to (2) above after a
> period of time (perhaps when we drop F6?)

Expanding on this to explain my reasoning:

my view is that defaults.cfg should be empty for default mock install.
All of the default settings should be in mock.py, and defaults.py should
be for sitewide customizations by the admin.

Looking at the current defaults.cfg, we can remove all of the entries as
they are redudnant (use_host_resolv, use_cache, chrootuid, and chrootgid
all need to be migrated).

I've pushed my proposed changes for defaults.cfg (not including this
patch) to http://linux.dell.com/git/mock.git
--
Michael