[PATCH] don't break lines in logOutput (bz#467470)
Mike McLean
mikem at redhat.com
Tue Nov 11 18:35:07 UTC 2008
Mike McLean wrote:
>
> Signed-off-by: Mike McLean <mikem at redhat.com>
> ---
> py/mock/util.py | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
Note, I removed the chomp() call since we're already splitting on '\n',
hence none of the entries in the split can contain '\n'.
We may want to remove the chomp function from util.py as this appears to
have been its only use.
Also, how would folks feel about removing the "if line == '': continue"
bit? Empty lines in the output are still output after all. My main
concern here is that the build.log produced by mock should be as
accurate as possible.
Context:
https://bugzilla.redhat.com/show_bug.cgi?id=467470
https://fedorahosted.org/koji/ticket/113
More information about the Fedora-buildsys-list
mailing list