rpms/gnome-panel/devel gnome-panel-2.18.0-fix-invalid-read.patch, NONE, 1.1 gnome-panel.spec, 1.192, 1.193

[fedora-cvs-commits at redhat.com]

Author: rstrode

Update of /cvs/dist/rpms/gnome-panel/devel
In directory cvs.devel.redhat.com:/tmp/cvs-serv27217

Modified Files:
	gnome-panel.spec 
Added Files:
	gnome-panel-2.18.0-fix-invalid-read.patch 
Log Message:
- fix invalid read and potentially fix 234544


gnome-panel-2.18.0-fix-invalid-read.patch:
 panel-run-dialog.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+)

--- NEW FILE gnome-panel-2.18.0-fix-invalid-read.patch ---
--- gnome-panel-2.18.0/gnome-panel/panel-run-dialog.c.fix-invalid-read	2007-04-04 15:35:14.000000000 -0400
+++ gnome-panel-2.18.0/gnome-panel/panel-run-dialog.c	2007-04-04 15:40:24.000000000 -0400
@@ -111,6 +111,8 @@
 
 static PanelRunDialog *static_dialog = NULL;
 
+static void panel_run_dialog_disconnect_pixmap (PanelRunDialog *dialog);
+
 static void
 panel_run_dialog_destroy (PanelRunDialog *dialog)
 {
@@ -165,6 +167,8 @@
 	if (dialog->completion)
 		g_completion_free (dialog->completion);
 	dialog->completion = NULL;
+
+	panel_run_dialog_disconnect_pixmap (dialog);
 	
 	g_free (dialog);
 }
@@ -1905,6 +1909,17 @@
 }
 
 static void
+panel_run_dialog_disconnect_pixmap (PanelRunDialog *dialog)
+{
+	g_signal_handlers_disconnect_by_func (dialog->pixmap,
+			                      G_CALLBACK (panel_run_dialog_style_set),
+			                      dialog);
+	g_signal_handlers_disconnect_by_func (dialog->pixmap,
+			                      G_CALLBACK (panel_run_dialog_screen_changed),
+			                      dialog);
+}
+
+static void
 panel_run_dialog_static_dialog_destroyed (PanelRunDialog *dialog)
 {
 	/* just reset the static dialog to NULL for next time */


Index: gnome-panel.spec
===================================================================
RCS file: /cvs/dist/rpms/gnome-panel/devel/gnome-panel.spec,v
retrieving revision 1.192
retrieving revision 1.193
diff -u -r1.192 -r1.193
--- gnome-panel.spec	4 Apr 2007 16:28:42 -0000	1.192
+++ gnome-panel.spec	4 Apr 2007 19:50:27 -0000	1.193
@@ -22,7 +22,7 @@
 Summary: GNOME panel
 Name: gnome-panel
 Version: 2.18.0
-Release: 7%{?dist} 
+Release: 8%{?dist} 
 URL: http://www.gnome.org
 Source0: http://ftp.gnome.org/pub/GNOME/sources/gnome-panel/2.18/%{name}-%{version}.tar.bz2
 Source1: redhat-panel-default-setup.entries
@@ -104,6 +104,9 @@
 # http://bugzilla.gnome.org/show_bug.cgi?id=426281
 Patch20: gnome-panel-2.18.0-fix-name-too-long-error.patch
 
+# http://bugzilla.gnome.org/show_bug.cgi?id=413921
+Patch21: gnome-panel-2.18.0-fix-invalid-read.patch
+
 Conflicts: gnome-power-manager < 2.15.3
 
 %description
@@ -139,6 +142,7 @@
 %patch18 -p1 -b .hide-lock-menu-if-root
 %patch19 -p1 -b .update-clock-immediately
 %patch20 -p1 -b .fix-name-too-long-error
+%patch21 -p1 -b .fix-invalid-read
 
 . %{SOURCE4}
 
@@ -319,6 +323,9 @@
 %{_datadir}/gtk-doc
 
 %changelog
+* Wed Apr  4 2007 Ray Strode <rstrode at redhat.com> - 2.18.0-8
+- fix invalid read and potentially fix 234544
+
 * Wed Apr  4 2007 Ray Strode <rstrode at redhat.com> - 2.18.0-7
 - Allow users to correct desktop launchers when given an 
   error initially (bug 233015)