Spec file help

[Gavin Henry]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 06 February 2004 21:39, Karsten Hopp wrote:
> On Fri, Feb 06, 2004 at 09:27:23PM +0000, Gavin Henry wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Dear all,
> >
> > I know everyone is extremely busy, but if someone has time to check over
> > my first spec file and give me some feedback/pointers, it would be
> > greatly appreciated.
> >
> > It was made with Mach and installs on FC1 and RH9 fine.
> >
> > Thanks,
> >
> > Gavin.
> >
> > url: http://www.suretecsystems.com/docs/netmon_applet.spec
>
> A few comments:
> > Source0        :
> > http://www.demonseed.net/~jp/code/netmon_applet/netmon_applet-0.4.tar.gz
>
> It's better to use %{version} here. Otherwise you'd have to change the
> version at two places when you update to p.e. 0.5
>
> >BuildRoot      : %{_tmppath}/%{name}-{buildroot}
>
> Missing % ?                           ^
>
> >./configure 				\
> >	--libdir=%{_libdir}		\
> >	--bindir=%{_bindir}		\
> >	--datadir=%{_datadir}		\
> >	--sysconfdir=%{_sysconfdir}
>
> Use %configure, this sets those parameters automatically. Check
> /usr/lib/rpm/macros so see the complete %configure macro.

So I added %{buildroot} and do I just take out all the --libdir=%{_libdir} 
stuff and put %configure instead yeah?

Thanks for the quick responses though.

- -- 
Regards,

Gavin Henry.
Director.

Open Source. Open Solutions.
http://www.suretecsystems.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAJBCTeWseh9tzvqgRApFoAJ97Veb2HF6nXXsJb6cRSxyI32a7uACff5j2
/mH7lWhNbIMhlOcvfhcfplo=
=tK+q
-----END PGP SIGNATURE-----