[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: mock 0.8.9





On Dec 7, 2007 5:58 AM, Paulo Cavalcanti <promac gmail com> wrote:


On Dec 7, 2007 5:04 AM, Michael E Brown <Michael_E_Brown dell com> wrote:
On Wed, Dec 05, 2007 at 07:56:11PM -0200, Paulo Cavalcanti wrote:
> On Dec 5, 2007 7:45 PM, Ville Skyttä <ville skytta iki fi> wrote:
>
> > On Wednesday 05 December 2007, Michael E Brown wrote:
> > > On Tue, Dec 04, 2007 at 04:59:07PM -0500, Todd Zullinger wrote:
> > > > Okay, here's another set of patches to implement --with{,out} options.
> > > > I used git-format-patch this time, and probably did it awkwardly.  But
> > > > hopefully not too badly.  Just in case (and for non-git users), I'll
> > > > also attach a single diff that should apply cleanly to mock-0.8.14.
> > > >
> > > > Comments and improvements welcome. :)
> > >
> > > This looks great to me. I've committed this to the repo.
> >
> > Thanks, guys!  When there's a mock release out with these changes
> > (assuming
> > they work :)), I think mock has finally caught up with essential features
> > in
> > mach and I'm ready to start using mock.
> >
> The only issue  I have so far is during init:
>
>
> mock -r fedora-7-i386 init
>
> INFO: mock.py version 0.8.14 starting...
> State Changed: init plugins
> State Changed: start
> State Changed: lock buildroot
> State Changed: clean
> State Changed: init
> State Changed: lock buildroot
> INFO: enabled yum cache
> State Changed: cleaning yum metadata
> INFO: enabled root cache
> State Changed: running yum
> ERROR: Command failed. See logs for output.
>  # mount -n --bind /home/mock/cache/fedora-7-i386/yum_cache/
> /home/mock/fedora-7-i386/root/var/cache/yum
>
>  But if the chroot is already initialized by a previous mock version, them
> everything goes fine.
>
> I have an updated mock rpm if anyone else is willing to try it.

Mock 0.8.15 is in updates-stable now and has a fix for this problem.

Thanks!

I installed  mock 0.8.15 yesterday and I did not see any problem yet.
This version seems to be very good.


Hi,

The --without option is not working.

I think that

    options.rpmmacros.append("_with_%s 0" % option)

should be replaced for

    options.rpmmacros.append("_without_%s 1" % option)

I am appending a patch to fix it

Thanks.


--
Paulo Roma Cavalcanti
LCG - UFRJ
diff -Naur mock-0.8.15/py/mock.py mock-0.8.15-new/py/mock.py
--- mock-0.8.15/py/mock.py	2007-12-06 03:09:01.000000000 -0200
+++ mock-0.8.15-new/py/mock.py	2007-12-08 22:45:46.000000000 -0200
@@ -234,7 +234,7 @@
         options.rpmmacros.append("_with_%s 1" % option)
 
     for option in options.rpmwithout:
-        options.rpmmacros.append("_with_%s 0" % option)
+        options.rpmmacros.append("_without_%s 1" % option)
 
     for macro in options.rpmmacros:
         try:

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]