[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: short koji repo question



On 10/04/2007 12:19 PM, Jesse Keating wrote:
> On Wed, 03 Oct 2007 22:36:20 +0200
> Oliver Falk <oliver linux-kernel at> wrote:
> 
>> Is there any good reason, why koji doesn't also create the sqlite
>> database with createrepo (passing -d option)?
>>
>> For slow arches, it would speed up the init phase of the build-root...
>> For the fast arches, well it would also be faster I think...
>>
>> If someone is going to change/try that. Let me know the progress. I
>> tried that on our Alpha Koji, but encountered a problem...
> 
> Mostly because the development of koji happened mostly on RHEL4/5
> machines which lack a createrepo that can do -d.
> 
> 

Well. Sooner or later you'll have sqlite support for createrepo on your
machines and then:

--- /usr/sbin/kojid     2007-10-04 13:36:32.000000000 +0200
+++ /tmp/kojid  2007-10-04 13:36:15.000000000 +0200
@@ -2244,7 +2244,7 @@
         outdir = "%s/repo" % self.workdir
         datadir = "%s/repodata" % outdir
         koji.ensuredir(outdir)
-        cmd = ['/usr/bin/createrepo', '-vpd', '--outputdir', outdir]
+        cmd = ['/usr/bin/createrepo', '-vp', '--outputdir', outdir]
         if os.path.exists("%s/comps.xml" % repodir):
             cmd.extend(['-g', 'comps.xml'])
         #attempt to recycle repodata from last repo
@@ -2272,7 +2272,7 @@

         files = []
         for f in os.listdir(datadir):
-            if f.endswith('.xml') or f.endswith('.xml.gz') or
f.endswith('.bz2'):
+            if f.endswith('.xml') or f.endswith('.xml.gz'):
                 files.append(f)
                 session.uploadWrapper("%s/%s" % (datadir, f),
uploadpath, f)


I can do more digging and check if I can add some config key and >if<
that two lines of code... Or we simply check which version of createrepo
introduced -d and BR it in koji spec...

I can also open a ticket on hosted, if you prefer!?

Best,
 Oliver


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]