[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: major boost breakage

On Tue, Aug 12, 2008 at 03:50:27AM -0700, Alex Lancaster wrote:
> It doesn't seem seem like a good idea to update a package that can
> cause some major ABI/API breakage only 2 weeks before the Beta freeze,
> without evaluating the fallout from potential broken deps.  This
> really should have been not only announced, but discussed before doing
> the soname bump.

Ok, I can see I've screwed on several levels here (underestimating how
many packages depend on boost, not realizing how far into release
cycle Fedora is).  So I can have boost un-tagged by releng right away,
and break the next rawhide to come.

Still, while I see some big packages (abiword, inkscape), I suspect
that most incompatibilities can be fixed simply (i.e. mostly sed-style
fixes), and I can help people with fixing their build failures
(attaching Miro patch right away).

diff -urp Miro-1.2.4/portable/libtorrent/include/libtorrent/disk_io_thread.hpp Miro-1.2.4-pm/portable/libtorrent/include/libtorrent/disk_io_thread.hpp
--- Miro-1.2.4/portable/libtorrent/include/libtorrent/disk_io_thread.hpp	2008-05-28 16:05:15.000000000 +0200
+++ Miro-1.2.4-pm/portable/libtorrent/include/libtorrent/disk_io_thread.hpp	2008-08-12 13:24:32.000000000 +0200
 #include <boost/bind.hpp>
 #include <boost/pool/pool.hpp>
 #include <boost/noncopyable.hpp>
+#include <boost/thread/condition.hpp>
 #include "libtorrent/config.hpp"
 namespace libtorrent
diff -urp Miro-1.2.4/portable/libtorrent/src/torrent_info.cpp Miro-1.2.4-pm/portable/libtorrent/src/torrent_info.cpp
--- Miro-1.2.4/portable/libtorrent/src/torrent_info.cpp	2008-05-28 16:05:16.000000000 +0200
+++ Miro-1.2.4-pm/portable/libtorrent/src/torrent_info.cpp	2008-08-12 13:29:02.000000000 +0200
@@ -352,7 +352,7 @@ namespace libtorrent
 		fs::path tmp = m_name;
 		if (tmp.is_complete()) throw std::runtime_error("torrent contains "
 			"a file with an absolute path: '" + m_name + "'");
-		if (tmp.has_branch_path()) throw std::runtime_error(
+		if (!tmp.branch_path().empty()) throw std::runtime_error(
 			"torrent contains name with directories: '" + m_name + "'");
 		// extract file list
@@ -556,7 +556,7 @@ namespace libtorrent
 //		TORRENT_ASSERT(file.begin() != file.end());
-		if (!file.has_branch_path())
+		if (file.branch_path().empty())
 			// you have already added at least one file with a
 			// path to the file (branch_path), which means that

Attachment: pgptVIhaHxtzx.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]