[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/git/devel .cvsignore, 1.63, 1.64 git.spec, 1.70, 1.71 sources, 1.63, 1.64



James Bowes wrote:
> Log Message:
> git 1.6.0.1
[...]
> Index: git.spec
> ===================================================================
> RCS file: /cvs/extras/rpms/git/devel/git.spec,v
> retrieving revision 1.70
> retrieving revision 1.71
> diff -u -r1.70 -r1.71
> --- git.spec	24 Jul 2008 14:03:40 -0000	1.70
> +++ git.spec	28 Aug 2008 12:16:58 -0000	1.71
> @@ -132,6 +132,7 @@
> %build
> make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" \
>    ETC_GITCONFIG=/etc/gitconfig \
> +     gitexecdir=%{_bindir} \
>    prefix=%{_prefix} all %{!?_without_docs: doc}
> make -C contrib/emacs
> 
> @@ -140,6 +141,7 @@
> make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" DESTDIR=$RPM_BUILD_ROOT \
>    prefix=%{_prefix} mandir=%{_mandir} \
>    ETC_GITCONFIG=/etc/gitconfig \
> +     gitexecdir=%{_bindir} \
>    INSTALLDIRS=vendor install %{!?_without_docs: install-doc}
> make -C contrib/emacs install \
> 		 emacsdir=$RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp

I almost hate to ask, but why are we differing from upstream here by
setting gitexecdir=%{_bindir}?  Moving the git-* commands out of the
path has been on the agenda for git-1.6.0 for a long time.  If distros
like Fedora and others just set gitexecdir like this we've effectively
negated upstream's intent to present less binaries in the users path.

For those folks that want to continue using the git-* form, the simple
solution is to add $(git --exec-path) to PATH.

If we want to not break anyone's scripts by default in the update to
git-1.6.0, we could add that to the PATH in the package rather than
keep all the git binaries in %{_bindir}.  At least that way, those who
do not want or need all the extra commands there could just remove it
from their PATH.  (Personally, I'd prefer to not even do that and
install git as closely to upstream as possible.)

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Never argue with an idiot. First, they drag you down to their level,
then beat you with experience.
    -- Ben Adams

Attachment: pgp7HpTKHlYaz.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]