[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/elfinfo/devel elfinfo.spec,1.2,1.3



On Wed, 3 Dec 2008 15:06:48 +0530, Parag wrote:

>      Looks like beacuse of this mistake elfinfo was building fine
> previously. But now after correcting it, build is failed. But if i remove
> CFLAGS then build is sucessfull.

Veto.

Fix it please. Patch attached.

Also note that running programs in quiet make mode (like "@gcc") is
something your reviewer should have blocked in reviews. We want build
output in the logs.

-- 
Michael Schwendt <mschwendt fedoraproject org>
Fedora release 10 (Cambridge) - Linux 2.6.27.5-117.fc10.i686
loadavg: 1.11 1.19 1.21

Attachment: elfinfo-1.1-build.patch
Description: Binary data

Attachment: elfinfo.spec.patch
Description: Binary data


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]