[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rpms/elfinfo/devel elfinfo.spec,1.2,1.3



Hi,

2008/12/3 Michael Schwendt <mschwendt gmail com>
On Wed, 3 Dec 2008 15:06:48 +0530, Parag wrote:

>      Looks like beacuse of this mistake elfinfo was building fine
> previously. But now after correcting it, build is failed. But if i remove
> CFLAGS then build is sucessfull.

Veto.

Fix it please. Patch attached.

Also note that running programs in quiet make mode (like "@gcc") is
something your reviewer should have blocked in reviews. We want build
output in the logs.
      
      Thanks for your patches. Unfortunately, I was the reviewer for this package and took over from initial ower in F11/EPEL branch. I will make sure this to check "@gcc" thing now onwards.
Regards,
Parag.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]