[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: rawhide report: 20081219 changes



On Fri, 2008-12-19 at 12:40 +0100, Michael Schwendt wrote:
> On Fri, 19 Dec 2008 10:48:38 +0000 (UTC), Rawhide wrote:
> 
> > geeqie-1.0-0.11.alpha2.1299svn.fc11
> > -----------------------------------
> > * Thu Dec 18 17:00:00 2008 Rex Dieter <rdieter fedoraproject org> - 1.0-0.9.alpha2
> > - respin (exiv2)
> > 
> > * Thu Dec 18 17:00:00 2008 Michael Schwendt <mschwendt fedoraproject org> - 1.0-0.11.alpha2.1299svn
> > - drop desktop file Exec= invocation patch (no longer necessary)
> > 
> > * Thu Dec 18 17:00:00 2008 Michael Schwendt <mschwendt fedoraproject org> - 1.0-0.10.alpha2.1299svn
> > - update to svn 1299 for new exiv2
> > - disable LIRC support which is broken
> 
> The incorrect sorting is a bug in createrepo. The changelog entries need to stay
> in order, as they cannot be sorted by timestamp. The timestamps refer to full days
> lacking hours/mins/secs details.

 Actually it's in yum itself now, I think this is the fix:

diff --git a/yum/packages.py b/yum/packages.py
index acfb9f0..da4d0d8 100644
--- a/yum/packages.py
+++ b/yum/packages.py
@@ -928,7 +928,7 @@ class YumAvailablePackage(PackageObject, RpmBase):
             return ""
         msg = "\n"
         clog_count = 0
-        for (ts, author, content) in reversed(sorted(self.changelog)):
+        for (ts, author, content) in reversed(self.changelog):
             if clog_limit and clog_count >= clog_limit:
                 break
             clog_count += 1

...while I'm 99% sure the above is good, I'm not going to apply that
upstream/rawhide atm. ... due to the current real world date/time thing.

> repodiff can't fix this. I've had a look. It sorts the changelog entries
> by timestamp, which is another bug (= probably an attempt at trying
> to work around the createrepo bug).

 The sort is useless, yes ... but it's not sorting what is output, so
it's not doing any harm either.

> Printing only the date can be done with attached patch, however.

 Applied.

-- 
James Antill <james fedoraproject org>
Fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]